[Lldb-commits] [lldb] 738d73f - [lldb] Update the lldb build instructions on Windows

[Stella Stamenova via lldb-commits]

Author: Stella Stamenova
Date: 2022-01-28T10:18:19-08:00
New Revision: 738d73fbf4edc1ae4e6fc2e40f734df267420420

URL: https://github.com/llvm/llvm-project/commit/738d73fbf4edc1ae4e6fc2e40f734df267420420
DIFF: https://github.com/llvm/llvm-project/commit/738d73fbf4edc1ae4e6fc2e40f734df267420420.diff

LOG: [lldb] Update the lldb build instructions on Windows

The existing instructions for lldb on Windows can be more explicit. This adds a few details on how to install various components and the easiest way to get to a working build.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D118425

Added: 
    

Modified: 
    lldb/docs/resources/build.rst

Removed: 
    


################################################################################
diff  --git a/lldb/docs/resources/build.rst b/lldb/docs/resources/build.rst
index aadd57aedf882..c333134408f1d 100644
--- a/lldb/docs/resources/build.rst
+++ b/lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@ Windows
 * `GnuWin32 <http://gnuwin32.sourceforge.net/>`_ for CoreUtils and Make.
 * `Python 3 <https://www.python.org/downloads/windows/>`_.  Make sure to (1) get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  <https://github.com/Microsoft/PTVS/releases>`_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  <https://github.com/Microsoft/PTVS/>`_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows <http://www.swig.org/download.html>_`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``<GnuWin32 install dir>\bin`` is added to
    your PATH environment variable. Verify that utilities like ``dirname`` and
    ``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure ``<SWIG install dir>`` is added to
    your PATH environment variable. Verify that ``swig`` is available from your
    terminal.
+#. Install Python 3 from the standalone installer and include the debug libraries
+   in the install, making sure the Python install path is added to your PATH
+   environment variable.
 #. Register the Debug Interface Access DLLs with the Registry from a privileged
    terminal.
 
@@ -119,9 +125,10 @@ process. They only need to be performed once.
 > regsvr32 "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\DIA SDK\bin\amd64\msdia140.dll"
 
 Any command prompt from which you build LLDB should have a valid Visual Studio
-environment setup. This means you should run ``vcvarsall.bat`` or open an
-appropriate Visual Studio Command Prompt corresponding to the version you wish
-to use.
+environment setup. This means you should open an appropriate `Developer Command
+Prompt for VS <https://docs.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2019>`_
+corresponding to the version you wish to use or run ``vcvarsall.bat`` or
+``VsDevCmd.bat``.
 
 macOS
 *****