[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

[Med Ismail Bennani via Phabricator via lldb-commits]

mib updated this revision to Diff 404068.
mib added a reviewer: jingham.
mib added a comment.

Address @jingham concerns by making this fully optional:

- Change python default value to 0. Thread indices in lldb are 1-based, so 0 sounds like a good error_value.
- Check for python returned integer and replace it by `LLDB_INVALID_INDEX32` to prevent `ScriptedProcess::RefreshStateAfterStop` to select a thread with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118482/new/

https://reviews.llvm.org/D118482

Files:
  lldb/examples/python/scripted_process/scripted_process.py
  lldb/include/lldb/Interpreter/ScriptedProcessInterface.h
  lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.h
  lldb/test/API/functionalities/scripted_process/stack_core_scripted_process.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118482.404068.patch
Type: text/x-patch
Size: 4117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220128/7d25279a/attachment-0001.bin>