[Lldb-commits] [PATCH] D118091: [lldb] Remove ConstString::StaticMemorySize

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, clayborg, kastiglione.
JDevlieghere requested review of this revision.

Remove `ConstString::StaticMemorySize` as it is unused. It is referenced in a bunch of doc comments but I don't really understand why. My best guess it that the comments were copy-pasted from `ConstString::MemorySize()` even though it didn't make sense there either. The implementation of `StaticMemorySize` was being called on the MemoryPool, not on the ConstString itself.


https://reviews.llvm.org/D118091

Files:
  lldb/include/lldb/Core/Declaration.h
  lldb/include/lldb/Core/FileSpecList.h
  lldb/include/lldb/Core/Mangled.h
  lldb/include/lldb/Symbol/Function.h
  lldb/include/lldb/Utility/ConstString.h
  lldb/include/lldb/Utility/FileSpec.h
  lldb/source/Utility/ConstString.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118091.402727.patch
Type: text/x-patch
Size: 5066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220125/74384338/attachment.bin>