[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 20 16:11:54 PST 2022

omjavaid added inline comments.

Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:70
+        # 1. It tries to search a gigantic amount of memory.
+        #    We're not going to to test for this because a failure
+        #    would take a very long time and perhaps even find the
to to => to

Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:83
+        # Then that the location found does not display the tag bits.
+        self.assertNotRegexpMatches(out, "data found at location: 0x(34|56)[0-9A-Fa-f]+")
so I am thinking do we actually need to omit tags from location address. Internally we want LLDB to ignore tags thats fine but user must be seeing the tagged address of buf so why omit tags in output of memory find?

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list