[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

Thu Jan 20 14:32:52 PST 2022

omjavaid added a comment.

In D117676#3254662 <https://reviews.llvm.org/D117676#3254662>, @labath wrote:

> FWIW, I consider the build.py script a failed experiment. The idea itself was not completely bad, but the lack of buy-in from sufficient amount of developers meant that it never really had a chance of fulfilling its (rather lofty) goals.
>
> I think it should be removed or at least scaled back significantly. The only thing it's really used for these days is to invoke msvc and clang-cl, and I'm sure we can achieve the same thing with some lit substitutions as well...

The script actually worked fairly well for Windows on Arm use-case. Although some tests like this one is written with only x86/x64 windows in mind so there will be minor tweaking required here n there.

In D117676#3254687 <https://reviews.llvm.org/D117676#3254687>, @labath wrote:

> To put it in a more constructive light, what I was trying to say that if you find yourself spending a lot of time struggling with the script, definitely down be afraid to strip it down, change how it works, or remove it completely.

I also plan to do some windows cleanup but immediate goal is to have LLDB windows Arm buildbot up and running with maximum number of passing tests.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117676/new/

https://reviews.llvm.org/D117676