[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Utility/Instrumentation.h:23
+
+template <typename T,
+          typename std::enable_if<std::is_fundamental<T>::value, int>::type = 0>
----------------
I didn't notice this before, but I think this should really be in some namespace, ideally even separated from the rest of "normal" code. `lldb_private::instrumentation` perhaps?


================
Comment at: lldb/include/lldb/Utility/Instrumentation.h:84
+
+  struct EmptyArg {};
+
----------------
I guess this is not used?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117712/new/

https://reviews.llvm.org/D117712