[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 19 12:48:08 PST 2022

JDevlieghere added a comment.

In D117712#3255978 <https://reviews.llvm.org/D117712#3255978>, @labath wrote:

> It seems the set of macros could be reduced. If you don't need to generate "unique identifiers" for each method, then you can stop worrying about const methods, constructors, etc. I think this could boil down to one or two macros...

Yeah, I think we can reduce everything to:

  #define LLDB_INSTRUMENT(...)                                                   \
    lldb_private::Instrumenter _instrumenter(LLVM_PRETTY_FUNCTION, __VA_ARGS__);

plus a variant that takes no args. The reason it's not part of this patch is because it means modifying every single line and I'm lazy^Z^Z^Z^Z not sure when I'll have the time for that. Maybe I'll just revive lldb-instr locally and have it generate the new macros for me.



More information about the lldb-commits mailing list