[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Do you actually care about the timers or is this really about getting these methods instrumented with signposts on our platform? If it's the latter, I think it would make more sense to put that call in the `LLDB_RECORD_*` macros (which I'm planning to rename imminently). If this is about instrumenting the API, we can use the old reproducer logic to differentiate between calls made across the API boundary. Maybe it would make sense to only instrument external calls.

If it's just the signposts I'm not worried about performance, there's no way that's slower than the old reproducer instrumentation :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117632/new/

https://reviews.llvm.org/D117632