[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

[Nico Weber via Phabricator via lldb-commits]

thakis added a comment.

> So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if used in a static library?

Do you mean define it for all targets, instead of for just liblldb?

If just for liblldb, then the link fails because (e.g.) driver tries to dllimport the symbols in liblldb then.

If you mean "define for everything", I haven't checked (since it's inconvenient to do).

To be clear, this isn't a huge problem for me, I'll just switch to a dll on Windows. The old system just seemed more flexible than the new setup, without being more complicated. (Maybe you're planning to do some followup that requires this change.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117564/new/

https://reviews.llvm.org/D117564