[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359
+void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() {
+#ifdef __APPLE__
+  if (!m_objc_module_sp)
----------------
JDevlieghere wrote:
> jingham wrote:
> > Why is this code #ifdef APPLE?
> > 
> > If you were debugging from a Linux machine to a macOS system, wouldn't you also want to at least see the warning so you would know why their session was slow?
> My reasoning was that the error wouldn't be actionable so I'd rather not show it all. I don't feel strongly about it though. 
It would save people wasting time to try to figure out why this seemed slow, which is worth something on its own.  And the Linux user could expand the cache on the Mac, copy it over and lldb should be able to use it - with "target modules add" by hand if nothing more automatic works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117623/new/

https://reviews.llvm.org/D117623