[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

So, sadly, I am going to have to backtrack here. When I set `LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me.

Running the tests with this current change to default `LLDB_USE_LLDB_SERVER` to ON has significantly more failures than without. I haven't investigated yet exactly where the failures are coming from, but I did figure out that by default not all variables from the environment are preserved when the tests are executed, so my setting of `LLDB_USE_LLDB_SERVER` locally did absolutely nothing and it wasn't until it was defaulted to ON that the tests ran as intended.

I'm going to spend a bit of time to see if I can figure out where the failures are coming from, but I suspect it won't be trivial. One of the fun new errors is: `error: Execution was interrupted, reason: Attempted to dereference an invalid pointer..`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117581/new/

https://reviews.llvm.org/D117581