[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added a subscriber: JDevlieghere.

This does not build correctly with gcc 7.3.1 on CentOS:

  /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/resource/1/b/llvm/Release/tools/lldb/source/Plugins/Process/Linux -I/mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux -I/mnt/resource/1/s/llvm-project/lldb/include -I/mnt/resource/1/b/llvm/Release/tools/lldb/include -I/mnt/resource/1/b/llvm/Release/include -I/mnt/resource/1/s/llvm-project/llvm/include -I/mnt/resource/1/s/llvm-project/llvm/../clang/include -I/mnt/resource/1/b/llvm/Release/tools/lldb/../clang/include -I/mnt/resource/1/s/llvm-project/lldb/source -I/mnt/resource/1/b/llvm/Release/tools/lldb/source -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o -MF tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o.d -o tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o -c /mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
  /mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp: In member function ‘virtual llvm::Expected<std::unique_ptr<llvm::MemoryBuffer> > lldb_private::process_linux::NativeThreadLinux::GetSiginfo() const’:
  /mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:552:10: error: could not convert ‘siginfo_buf’ from ‘std::unique_ptr<llvm::WritableMemoryBuffer>’ to ‘llvm::Expected<std::unique_ptr<llvm::MemoryBuffer> >’
     return siginfo_buf;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117113/new/

https://reviews.llvm.org/D117113