[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

Sat Jan 15 14:55:55 PST 2022

gkistanova added inline comments.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:72
         "-DCMAKE_BUILD_TYPE=" + config,
+        "-DLLVM_LIT_ARGS='%s'" % lit_args,
         "-DCMAKE_INSTALL_PREFIX=../install",
----------------
To work as expected, this line should be wrapped in `WithProperties` either here, or each of the `cmake_options` items below before calling `CmakeCommand`.

And you do not need extra quotation marks around %s here, even if multiple options is specified for `-DLLVM_LIT_ARGS`.

Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116972/new/

https://reviews.llvm.org/D116972