[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 13 09:55:39 PST 2022
mib added a comment.
> I've never considered that 🤯 I'll update D117071 <https://reviews.llvm.org/D117071> to turn the `void*` into `std::shared_ptr<void>`.
I tried doing that (see attached patch below) but it doesn't work because even though the `StructuredData::Generic` is created with a `PyObject*`, it's stored as a `void*` and is retrieved in the `ScriptedThread` constructor using `void * StructuredData::Generic::GetValue() const`.
Making a `std::shared_ptr<void>` out of a `void *` doesn't work because it's an incomplete type.
@labath If you have any other suggestion, please let me know :-)
F21623387: share_ptr_void.diff <https://reviews.llvm.org/F21623387>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117139/new/
https://reviews.llvm.org/D117139
More information about the lldb-commits
mailing list