[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Target/Process.cpp:5891
+      // is at or beyond the end of mappable memory.
+      !(abi && (abi->FixDataAddress(range_end) != range_end)));
 
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > Just to confirm this assumes range base will always be free of any non-address-bits. ?
> Not always but the first range base that has non-address bits will be the range *after* the last mappable range. (end of last mappable range == begin of first unmappable range)
> 
> Since we only care about mappable regions here anyway, we can ignore the base addresses. (I'll add this in a comment too)
And for a mappable range to have non-address bits in the base the OS would have to report it that way. Which I can't say is completely out of the question but I don't see Linux doing it at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115508/new/

https://reviews.llvm.org/D115508