[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987
+NativeProcessLinux::GetSiginfo() const {
+  siginfo_t siginfo;
+  Status error = GetSignalInfo(GetCurrentThreadID(), &siginfo);
----------------
labath wrote:
> I'd be better to outright allocate a memory buffer of the right size (`getNewUninitMemBuffer`), and directly write the data there.
I suppose there's no similar solution for  the FreeBSD case where the returned struct is a member of the temporary struct?


================
Comment at: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py:1398
+        self.reset_test_sequence()
+        # TODO: freebsd doesn't report crashing thread in T
+        self.test_sequence.add_log_lines(
----------------
labath wrote:
> Didn't D117103 fix that?
Yeah, I left a comment, so I don't forget, then I've forgotten that I've left a comment ;-D.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117113/new/

https://reviews.llvm.org/D117113