[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29
+  ///     Non-null pointer to a memory tag manager.
+  MemoryTagMap(const MemoryTagManager *manager);
+
----------------
If the pointer should be non-null, then should this take a reference instead?


================
Comment at: lldb/include/lldb/Target/MemoryTagMap.h:46
+
+  bool empty() const;
+
----------------
I'm on the fence about this one. I personally prefer `empty()` for consistency with llvm and the standard library, but technically this should be `Empty()` to match the rest of LLDB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112825/new/

https://reviews.llvm.org/D112825