[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 12 03:48:58 PST 2022


labath added a comment.

It seems to me like the ScriptedThread class would benefit from using the fallible constructor idiom. If you move all the potentially failing operations (initialization of the ScriptedThreadInterface instance?) into a (public) `static Expected<ScriptedThreadInterfaceSP> Create(...)` method, then the constructor will not need the funky by-ref error argument, and it will be able to access the thread id sufficiently early.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117076/new/

https://reviews.llvm.org/D117076



More information about the lldb-commits mailing list