[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D116845#3232971 <https://reviews.llvm.org/D116845#3232971>, @zequanwu wrote:

>> The one part that bothers me is the "two-phased" setting of line tables. IIUC, the problem is that the inline line info is in the block descriptor, so you need to parse block info in order to create a line table, but in order to actually create an lldb_private::Block, you need the call site info from the caller, which is in the pdb line table. This creates a sort of a dependency loop, is that right?
>
> Yes. The temporary line table is in `CompileUnitIndex` now.

This looks better. Thanks.



================
Comment at: lldb/include/lldb/Symbol/LineTable.h:305-335
   struct EntrySearchInfo {
     LineTable *line_table;
     lldb_private::Section *a_section;
     Entry *a_entry;
   };
 
   // Types
----------------
The rest of this can stay protected, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116845/new/

https://reviews.llvm.org/D116845