[Lldb-commits] [lldb] 9b5cf72 - [lldb] Disable several lldb tests that are flaky on Windows

[Stella Stamenova via lldb-commits]

Author: Stella Stamenova
Date: 2022-01-10T10:21:12-08:00
New Revision: 9b5cf7267beb1e9c6f16402795890f0d02eb5145

URL: https://github.com/llvm/llvm-project/commit/9b5cf7267beb1e9c6f16402795890f0d02eb5145
DIFF: https://github.com/llvm/llvm-project/commit/9b5cf7267beb1e9c6f16402795890f0d02eb5145.diff

LOG: [lldb] Disable several lldb tests that are flaky on Windows

This tests have recently become flaky (flakier?) causing occasional failures in the windows lldb buildbot

Added: 
    

Modified: 
    lldb/test/API/commands/watchpoints/hello_watchlocation/TestWatchLocation.py
    lldb/test/API/commands/watchpoints/watchpoint_set_command/TestWatchLocationWithWatchSet.py
    lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/watchpoints/hello_watchlocation/TestWatchLocation.py b/lldb/test/API/commands/watchpoints/hello_watchlocation/TestWatchLocation.py
index 55bf929b25fcf..16fb71fd11302 100644
--- a/lldb/test/API/commands/watchpoints/hello_watchlocation/TestWatchLocation.py
+++ b/lldb/test/API/commands/watchpoints/hello_watchlocation/TestWatchLocation.py
@@ -37,6 +37,7 @@ def setUp(self):
     # SystemZ and PowerPC also currently supports only one H/W watchpoint
     @expectedFailureAll(archs=['powerpc64le', 's390x'])
     @skipIfDarwin
+    @skipIfWindows # This test is flaky on Windows
     def test_hello_watchlocation(self):
         """Test watching a location with '-s size' option."""
         self.build(dictionary=self.d)

diff  --git a/lldb/test/API/commands/watchpoints/watchpoint_set_command/TestWatchLocationWithWatchSet.py b/lldb/test/API/commands/watchpoints/watchpoint_set_command/TestWatchLocationWithWatchSet.py
index 53736a075f80f..92ea56021cc1b 100644
--- a/lldb/test/API/commands/watchpoints/watchpoint_set_command/TestWatchLocationWithWatchSet.py
+++ b/lldb/test/API/commands/watchpoints/watchpoint_set_command/TestWatchLocationWithWatchSet.py
@@ -34,6 +34,7 @@ def setUp(self):
             'aarch64',
             'arm'],
         bugnumber="llvm.org/pr26031")
+    @skipIfWindows # This test is flaky on Windows
     def test_watchlocation_using_watchpoint_set(self):
         """Test watching a location with 'watchpoint set expression -w write -s size' option."""
         self.build()

diff  --git a/lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py b/lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
index 7df728509c11c..9f1c6776d4a68 100644
--- a/lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
+++ b/lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
@@ -28,6 +28,7 @@ def setUp(self):
         # This is for verifying that watch location works.
         self.violating_func = "do_bad_thing_with_location"
 
+    @skipIfWindows # This test is flaky on Windows
     def test_watch_location(self):
         """Exercise SBValue.WatchPointee() API to set a watchpoint."""
         self.build()