[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

Mon Jan 10 10:17:32 PST 2022

kastiglione added a comment.

In D116788#3231612 <https://reviews.llvm.org/D116788#3231612>, @clayborg wrote:

> I would vote that if any argument or option is specified, and results in something not being found, that an error be returned.

Is this in response to my question about regexes? It seems to be. Specifically, you're of the opinion that any failing regex results in an error, even when other regexes do match? Your point about it not affecting the command line is a good point, thanks.

All your other points sound good to me too.

> Any tests that are failing now when they didn't before can be modified.

Yes there were a couple, D116901 <https://reviews.llvm.org/D116901> and D116863 <https://reviews.llvm.org/D116863>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116788/new/

https://reviews.llvm.org/D116788