[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

Mon Jan 10 04:18:23 PST 2022

mgorny added inline comments.

================
Comment at: lldb/test/API/functionalities/gdb_remote_client/amd64-fallback-regs.FileCheck:1
+CHECK-DAG: rax = 0x0807060504030201
+CHECK-DAG: rbx = 0x1817161514131211
----------------
labath wrote:
> I actually think it would be better if this was defined inline in the python file, as then you could intersperse these lines with the definitions (which you have already formatted in a way that makes this easy), and it would be immediately obvious that the two lines describe the same data (modulo endianness).
Using `self.match`, writing into a temporary file for FileCheck or do you have some other testing method on your mind?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116896/new/

https://reviews.llvm.org/D116896