[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 6 23:58:53 PST 2022


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Usually, the only thing one can do if a close fails is to log an error message, so it's not completely surprising that this has gone by unnoticed.

It might be nice to insert a close call to one of the existing Socket unit tests (or add a new one), but other than that, I am pretty sure this is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116768/new/

https://reviews.llvm.org/D116768



More information about the lldb-commits mailing list