[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Core/Debugger.cpp:1777
 
     if (auto single_lang = repl_languages.GetSingularLanguage()) {
       language = *single_lang;
----------------
As you said in the description, this is effectively dead code. Is this to be removed in a subsequent patch?


================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2265
+  if (language == eLanguageTypeUnknown) {
+    LanguageSet repl_languages = Language::GetLanguagesSupportingREPLs();
+    if (auto main_repl_language = repl_languages.GetSingularLanguage())
----------------
Is this case used by anyone? Should we just error out if it's unknown?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116697/new/

https://reviews.llvm.org/D116697