[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

Luís Ferreira via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 23 09:25:04 PST 2021

ljmf00 added a comment.

In D115662#3192735 <https://reviews.llvm.org/D115662#3192735>, @labath wrote:

> In D115662#3192651 <https://reviews.llvm.org/D115662#3192651>, @ljmf00 wrote:
>> In D115662#3192064 <https://reviews.llvm.org/D115662#3192064>, @labath wrote:
>>> I don't have any issues with this per se, but you may want to sync up with @zequanwu, as his D115308 <https://reviews.llvm.org/D115308> tries to delete the second instance.
>> Maybe he can reach out here, but how is this related to D115308 <https://reviews.llvm.org/D115308> ?
> You're right -- it isn't as related as I originally thought -- you're deduplicating the dietotype map, and he's doing it for the type list.
> But it still is related at least on a conceptual level, as both patches deal with recording information about the type, and would be good if those things could happen in a central place (and you seem to have picked different centralization points). Maybe there is a reason it has to be that way (I honestly don't know) but it at least seems like to be aware of each other's efforts.

In the meanwhile, D115308 <https://reviews.llvm.org/D115308> got merged. What are your final thoughts on this? I'm going to rebase and test locally but I'm confident that the merged changes doesn't have side effects here.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list