[Lldb-commits] [lldb] c3f0e1e - [LLDB][DWARF] Fix duplicate TypeSP in type list

[Zequan Wu via lldb-commits]

Author: Zequan Wu
Date: 2021-12-22T16:36:56-08:00
New Revision: c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac

URL: https://github.com/llvm/llvm-project/commit/c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac
DIFF: https://github.com/llvm/llvm-project/commit/c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac.diff

LOG: [LLDB][DWARF] Fix duplicate TypeSP in type list

Differential Revision: https://reviews.llvm.org/D115308

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 4ac6e165dda37..b90f104c4d213 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -1530,7 +1530,6 @@ TypeSP DWARFASTParserClang::UpdateSymbolContextScopeForType(
     return type_sp;
 
   SymbolFileDWARF *dwarf = die.GetDWARF();
-  TypeList &type_list = dwarf->GetTypeList();
   DWARFDIE sc_parent_die = SymbolFileDWARF::GetParentSymbolContextDIE(die);
   dw_tag_t sc_parent_tag = sc_parent_die.Tag();
 
@@ -1550,10 +1549,6 @@ TypeSP DWARFASTParserClang::UpdateSymbolContextScopeForType(
   if (symbol_context_scope != nullptr)
     type_sp->SetSymbolContextScope(symbol_context_scope);
 
-  // We are ready to put this type into the uniqued list up at the module
-  // level.
-  type_list.Insert(type_sp);
-
   dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
   return type_sp;
 }