[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

Wed Dec 22 05:21:05 PST 2021

mgorny marked 3 inline comments as done.
mgorny added inline comments.

================
Comment at: lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp:86
+#if defined(__FreeBSD__)
+    kvm_t *kvm =
+        kvm_open2(executable->GetFileSpec().GetPath().c_str(),
----------------
labath wrote:
> Do you really want to do this if the fvc call was successful? What is the expected priority of the two implementations? Maybe just use return statements instead of assignments?
Oh shi, I didn't notice that it doesn't use `return` statements. Fixed now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116005/new/

https://reviews.llvm.org/D116005