[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D115324#3198913 <https://reviews.llvm.org/D115324#3198913>, @stella.stamenova wrote:

> The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to see if it would be appropriate to modify somehow so it would work:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/12914
>
> (The bot is rather angry at me for the VS2019 update, but everything should be working OK again)

Fixed with:

commit 59f1d0eed58ce0f23c3a5a324d122a99f9757228 <https://reviews.llvm.org/rG59f1d0eed58ce0f23c3a5a324d122a99f9757228> (HEAD -> main, origin/main, origin/HEAD)
Author: Greg Clayton <gclayton at fb.com>
Date:   Thu Dec 16 16:13:58 2021 -0800

  Fix windows buildbots after https://reviews.llvm.org/D115324
  
  Windows has trouble deleting the executable due to permissions.

In D115324#3198913 <https://reviews.llvm.org/D115324#3198913>, @stella.stamenova wrote:

> The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to see if it would be appropriate to modify somehow so it would work:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/12914
>
> (The bot is rather angry at me for the VS2019 update, but everything should be working OK again)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115324/new/

https://reviews.llvm.org/D115324