[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 16 12:13:49 PST 2021


jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

The substance is fine, you kept the common cases fast and then added fallback for the others with the regex.

That test seems like an object lesson in what not to do in an inline test, but that wasn't your invention, so it's hard to complain too much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112709/new/

https://reviews.llvm.org/D112709



More information about the lldb-commits mailing list