[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

Thu Dec 16 04:40:24 PST 2021

danielkiss accepted this revision.
danielkiss added a comment.

In D103626#2824083 <https://reviews.llvm.org/D103626#2824083>, @DavidSpickett wrote:

>> Maybe this is something worth considering for LLDB memory dumps?
>
> I'm working on that at the moment, it's on my github branch. This is what it looks like with the right options: (others look weird at the moment due to ordering issues)
>
>   (lldb) memory read mte_buf mte_buf+32 -f "x" -l 1 -s 16
>   0xfffff7ff6000: 0x00000000000000000000000000000000 (tag: 0x0)
>   0xfffff7ff6010: 0x00000000000000000000000000000000 (tag: 0x1)
>
> The format is mostly a guess on my part, given that I'm mostly testing the debugger itself not MTE enabled software.

That looks really good, could help a lot to understand tagging related issues. Looking forward for that patch :)

This change LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103626/new/

https://reviews.llvm.org/D103626