[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 13 12:04:47 PST 2021


labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/bindings/lua/lua-wrapper.swig:31
    lldb::BreakpointLocationSP bp_loc_sp,
    StructuredDataImpl *extra_args_impl
 )
----------------
mib wrote:
> May be we should keep consistency with the `python-wrapper.swig` definition ?
Good point. This actually uncovered that I was now leaking this StructuredDataImpl object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114791/new/

https://reviews.llvm.org/D114791



More information about the lldb-commits mailing list