[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

John Ericson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Dec 12 08:57:40 PST 2021


Ericson2314 added inline comments.


================
Comment at: lldb/cmake/modules/AddLLDB.cmake:1
+include(GNUInstallDirs)
 function(lldb_tablegen)
----------------
I think a problem with D115544 was that `AddLLVM` was assuming `GNUInstallDirs` yet downstream packages didn't yet include it.

By starting with "leaf" packages I side-step this issue somewhat, but I am still putting these here defensively so that downstream projects that might include these aren't broken, and the precedent is set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115570/new/

https://reviews.llvm.org/D115570



More information about the lldb-commits mailing list