[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:139
+  // The actual QEMU_(UN)SET_ENV variables should not be forwarded to the
+  // target.
+  if (!set_env.empty()) {
----------------
DavidSpickett wrote:
> I glossed over this the first time, I assume you've observed this in testing. My first assumption was that qemu wouldn't pass them on but hard to tell from the sources. Probably some use case for it (emulating a second qemu-user?).
I'm not sure what's the use case, but yes, that is how it works. My guess it that it is simply because that is the easiest thing to do, and the user can always unset them himself in case he wants to (most of the time, it doesn't matter).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115246/new/

https://reviews.llvm.org/D115246