[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, bulbazord.
Herald added subscribers: tstellar, mgorny.
JDevlieghere requested review of this revision.

Instead of trying to squeeze `GetVersion` into `lldb-private.h`, give it its own header and implementation file in its own directory. I called it `Basic`, partially because the library was already called `lldbBase` (?) but mostly to align with `clang/Basic/Version.h` (and `swift/Basic/Version.h`) which might explain the current library name. but I'm pretty flexible as far as naming goes, I think `Version/Version.h` would work pretty well too.

Additional benefits of this patch include that we can get rid of the quoting macros and that other place of LLDB can read the version number from `Version.inc`. A downstream change requiring the latter was the main motivation for this patch. I considered adding a few other functions similar to what clang offers but decided against it since there would be no existing uses for them.


https://reviews.llvm.org/D115211

Files:
  lldb/include/lldb/Basic/Version.h
  lldb/include/lldb/Basic/Version.inc.in
  lldb/include/lldb/lldb-private.h
  lldb/source/API/CMakeLists.txt
  lldb/source/API/SBDebugger.cpp
  lldb/source/API/SBReproducer.cpp
  lldb/source/Basic/CMakeLists.txt
  lldb/source/Basic/Version.cpp
  lldb/source/CMakeLists.txt
  lldb/source/Commands/CMakeLists.txt
  lldb/source/Commands/CommandObjectVersion.cpp
  lldb/source/Initialization/SystemInitializerCommon.cpp
  lldb/source/lldb.cpp
  lldb/tools/lldb-server/CMakeLists.txt
  lldb/tools/lldb-server/lldb-server.cpp
  lldb/tools/lldb-test/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115211.392235.patch
Type: text/x-patch
Size: 11049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211207/91ed1128/attachment.bin>