[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

[walter erquinigo via Phabricator via lldb-commits]

wallace added a comment.

good job! Only some cosmetic changes are needed and you also need to delete the python code



================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:775-779
+  // AddCXXSummary(cpp_category_sp,
+  //               lldb_private::formatters::LibcxxOptionalSummaryProvider,
+  //               "libc++ std::optional summary provider",
+  //               ConstString("^std::__[[:alnum:]]+::optional<.+>(( )?&)?$"),
+  //               stl_summary_flags, true);
----------------
remove this


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:922-926
+  // cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
+  //     RegularExpression("^std::optional<.+>(( )?&)?$"),
+  //     SyntheticChildrenSP(new ScriptedSyntheticChildren(
+  //         stl_synth_flags,
+  //         "lldb.formatters.cpp.gnu_libstdcpp.StdOptionalSynthProvider")));
----------------
same here


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:950-954
+  // cpp_category_sp->GetRegexTypeSummariesContainer()->Add(
+  //     RegularExpression("^std::optional<.+>(( )?&)?$"),
+  //     TypeSummaryImplSP(new ScriptSummaryFormat(
+  //         stl_summary_flags,
+  //         "lldb.formatters.cpp.gnu_libstdcpp.StdOptionalSummaryProvider")));
----------------
same


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Generic.h:1-2
+//===-- LibCxx.h ---------------------------------------------------*- C++
+//-*-===//
+//
----------------
make this one line (=80 chars)


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Generic.h:10-11
+
+// #ifndef LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_LIBCXX_H
+// #define LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_LIBCXX_H
+
----------------
this shouldn't be a comment, and use
  LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_GENERIC_H


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Generic.h:26
+
+// #endif // LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_LIBCXX_H
----------------
LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_GENERIC_H


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/GenericOptional.cpp:1-2
+//===-- GenericOptional.cpp
+////-----------------------------------------------===//
+//
----------------
80 chars


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp:78-84
+// SyntheticChildrenFrontEnd *
+// formatters::LibcxxOptionalFrontEndCreator(CXXSyntheticChildren *,
+//                                           lldb::ValueObjectSP valobj_sp) {
+//   if (valobj_sp)
+//     return new OptionalFrontEnd(*valobj_sp);
+//   return nullptr;
+// }
----------------
delete this entire file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115178/new/

https://reviews.llvm.org/D115178