[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I am somewhat confused by this deduplication logic. I've read https://reviews.llvm.org/D113930#3136404, so I understand why the duplication is happening, but I don't understand _should_ it be happening. IIUC, `SymbolFileNativePDB::ParseTypes` tries to force the completion of all types. If it succeeds, then there should be no need to add anything else to that type. In fact, adding methods to an already-complete type sounds like a pretty bad idea.

While I'm not very familiar with PDBs or the process of clang ast creation, it sounds to me like there is something wrong here, and I want to make sure we're not using the deduplication to cover up some other issue. Were you able to understand (and ideally, explain) why we have the two parsing methods and why they end up trying to add the same method twice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113930/new/

https://reviews.llvm.org/D113930