[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

I would like to see more extensive test cases, for example alternating `public` and `private` specifiers for both `class` and `struct` case.



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1356
+    clang::AccessSpecifier previous_access = clang::AccessSpecifier::AS_none;
+    for (DeclContext::decl_iterator I = cxx_record_decl->decls_begin(),
+                                    E = cxx_record_decl->decls_end();
----------------
This feels a bit expensive, we have to go through all the fields every time we add a field. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115062/new/

https://reviews.llvm.org/D115062