[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 2 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/scripted_process/scripted_process.py:359
+                    ]
         return self.register_info
 
----------------
DavidSpickett wrote:
> Is it worth putting an `else: raise Unknown architecture <bla>` here? I assume the tests would fail later anyway and you're running this for Apple platforms that are x86/arm64 only.
> 
> Would this ever be run against Arm 32 bit?
Hi David,

Thanks for looking at this.

I didn't put the else branch because the C++ ScriptedThread caller would assert if the returned dictionary didn't have any entry.
After some considerations, it makes more sense to raise an error on the Python side and log the error in lldb.

Regarding arm32, we have no plans on supporting this architecture, but I think it should be quite straightforward to add.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114923/new/

https://reviews.llvm.org/D114923