[Lldb-commits] [lldb] c248601 - [lldb] Skip two lldb tests on Windows because they are flaky

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 2 09:53:36 PST 2021


Author: Stella Stamenova
Date: 2021-12-02T09:53:28-08:00
New Revision: c24860118a7e4fe0611a9463498181a4a01b9459

URL: https://github.com/llvm/llvm-project/commit/c24860118a7e4fe0611a9463498181a4a01b9459
DIFF: https://github.com/llvm/llvm-project/commit/c24860118a7e4fe0611a9463498181a4a01b9459.diff

LOG: [lldb] Skip two lldb tests on Windows because they are flaky

These tests work fine with VS2017, but become more flaky with VS2019 and the buildbot is about to get upgraded.

Differential Revision: https://reviews.llvm.org/D114907

Added: 
    

Modified: 
    lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
    lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py b/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
index 95499883aa7a2..697124003048c 100644
--- a/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ b/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -20,6 +20,7 @@ class ThreadSpecificBreakPlusConditionTestCase(TestBase):
     # hits break in another thread in testrun
     @add_test_categories(['pyapi'])
     @expectedFlakeyNetBSD
+    @skipIfWindows # This test is flaky on Windows
     def test_python(self):
         """Test that we obey thread conditioned breakpoints."""
         self.build()

diff  --git a/lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py b/lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
index 4fdde97dba084..9467adb6cffe3 100644
--- a/lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
+++ b/lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
@@ -89,6 +89,7 @@ def test_lldb_iter_breakpoint(self):
             self.assertEqual(yours[i], mine[i],
                             "ID of yours[{0}] and mine[{0}] matches".format(i))
 
+    @skipIfWindows # This test is flaky on Windows
     def test_lldb_iter_frame(self):
         """Test iterator works correctly for SBProcess->SBThread->SBFrame."""
         self.build()


        


More information about the lldb-commits mailing list