[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 2 04:07:06 PST 2021


DavidSpickett added a comment.

Looking at `GetOneMoreFrame` I agree the logic matches up but don't understand the logic enough overall to approve. I'll leave that to others.



================
Comment at: lldb/source/Target/RegisterContextUnwind.cpp:697
+  // theory we can have arbitrary number of frames with the same CFA, but more
+  // then 2 is very very unlikely).
 
----------------
specail -> special
hanlders -> handlers
compiance -> compliance
more then 2 -> more than 2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114861/new/

https://reviews.llvm.org/D114861



More information about the lldb-commits mailing list