[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Target/Target.cpp:3324
 
-      if (default_to_use_pty &&
-          (!in_file_spec || !out_file_spec || !err_file_spec)) {
+      if (default_to_use_pty) {
         llvm::Error Err = info.SetUpPtyRedirection();
----------------
What's the logic to this change? I thought maybe the `!in_file_spec...` were redundant but not 100% sure.


================
Comment at: lldb/test/API/qemu/TestQemuLaunch.py:75
+
+        # Create a target using out platform
+        error = lldb.SBError()
----------------
out -> our?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114796/new/

https://reviews.llvm.org/D114796