[Lldb-commits] [lldb] 2e5c47e - Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h"

[Luís Ferreira via lldb-commits]

Author: Luís Ferreira
Date: 2021-11-30T00:52:53Z
New Revision: 2e5c47eda14a547c21e57d869a1e51ffd9938289

URL: https://github.com/llvm/llvm-project/commit/2e5c47eda14a547c21e57d869a1e51ffd9938289
DIFF: https://github.com/llvm/llvm-project/commit/2e5c47eda14a547c21e57d869a1e51ffd9938289.diff

LOG: Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h"

This reverts commit 6f99e1aa58e3566fcce689bc986b7676e818c038.

Added: 
    

Modified: 
    lldb/include/lldb/Symbol/Type.h
    lldb/source/Symbol/Type.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Symbol/Type.h b/lldb/include/lldb/Symbol/Type.h
index 5f0afdd94cd60..9e671a565dd14 100644
--- a/lldb/include/lldb/Symbol/Type.h
+++ b/lldb/include/lldb/Symbol/Type.h
@@ -67,27 +67,23 @@ class Type : public std::enable_shared_from_this<Type>, public UserID {
 public:
   enum EncodingDataType {
     eEncodingInvalid,
-    /// This type is the type whose UID is m_encoding_uid.
-    eEncodingIsUID,
-    /// This type is the type whose UID is m_encoding_uid with the const
-    /// qualifier added.
-    eEncodingIsConstUID,
-    /// This type is the type whose UID is m_encoding_uid with the restrict
-    /// qualifier added.
-    eEncodingIsRestrictUID,
-    /// This type is the type whose UID is m_encoding_uid with the volatile
-    /// qualifier added.
-    eEncodingIsVolatileUID,
-    /// This type is pointer to a type whose UID is m_encoding_uid.
-    eEncodingIsTypedefUID,
-    /// This type is pointer to a type whose UID is m_encoding_uid.
-    eEncodingIsPointerUID,
-    /// This type is L value reference to a type whose UID is m_encoding_uid.
-    eEncodingIsLValueReferenceUID,
-    /// This type is R value reference to a type whose UID is m_encoding_uid.
-    eEncodingIsRValueReferenceUID,
-    /// This type is the type whose UID is m_encoding_uid as an atomic type.
-    eEncodingIsAtomicUID,
+    eEncodingIsUID,      ///< This type is the type whose UID is m_encoding_uid
+    eEncodingIsConstUID, ///< This type is the type whose UID is m_encoding_uid
+                         /// with the const qualifier added
+    eEncodingIsRestrictUID, ///< This type is the type whose UID is
+                            /// m_encoding_uid with the restrict qualifier added
+    eEncodingIsVolatileUID, ///< This type is the type whose UID is
+                            /// m_encoding_uid with the volatile qualifier added
+    eEncodingIsTypedefUID,  ///< This type is pointer to a type whose UID is
+                            /// m_encoding_uid
+    eEncodingIsPointerUID,  ///< This type is pointer to a type whose UID is
+                            /// m_encoding_uid
+    eEncodingIsLValueReferenceUID, ///< This type is L value reference to a type
+                                   /// whose UID is m_encoding_uid
+    eEncodingIsRValueReferenceUID, ///< This type is R value reference to a type
+                                   /// whose UID is m_encoding_uid,
+    eEncodingIsAtomicUID,          ///< This type is the type whose UID is
+                                   /// m_encoding_uid as an atomic type.
     eEncodingIsSyntheticUID
   };
 
@@ -201,9 +197,9 @@ class Type : public std::enable_shared_from_this<Type>, public UserID {
 
   // From a fully qualified typename, split the type into the type basename and
   // the remaining type scope (namespaces/classes).
-  static bool GetTypeScopeAndBasename(const llvm::StringRef name,
-                                      llvm::StringRef scope,
-                                      llvm::StringRef basename,
+  static bool GetTypeScopeAndBasename(const llvm::StringRef& name,
+                                      llvm::StringRef &scope,
+                                      llvm::StringRef &basename,
                                       lldb::TypeClass &type_class);
   void SetEncodingType(Type *encoding_type) { m_encoding_type = encoding_type; }
 
@@ -477,8 +473,8 @@ class TypeEnumMemberImpl {
 public:
   TypeEnumMemberImpl() : m_integer_type_sp(), m_name("<invalid>"), m_value() {}
 
-  TypeEnumMemberImpl(const lldb::TypeImplSP &integer_type_sp, ConstString name,
-                     const llvm::APSInt &value);
+  TypeEnumMemberImpl(const lldb::TypeImplSP &integer_type_sp,
+                     ConstString name, const llvm::APSInt &value);
 
   TypeEnumMemberImpl(const TypeEnumMemberImpl &rhs) = default;
 

diff  --git a/lldb/source/Symbol/Type.cpp b/lldb/source/Symbol/Type.cpp
index 569d1bad165ce..5b4169d256d29 100644
--- a/lldb/source/Symbol/Type.cpp
+++ b/lldb/source/Symbol/Type.cpp
@@ -662,9 +662,9 @@ ConstString Type::GetQualifiedName() {
   return GetForwardCompilerType().GetTypeName();
 }
 
-bool Type::GetTypeScopeAndBasename(const llvm::StringRef name,
-                                   llvm::StringRef scope,
-                                   llvm::StringRef basename,
+bool Type::GetTypeScopeAndBasename(const llvm::StringRef& name,
+                                   llvm::StringRef &scope,
+                                   llvm::StringRef &basename,
                                    TypeClass &type_class) {
   type_class = eTypeClassAny;