[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 29 14:44:14 PST 2021


JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, jasonmolenda.
JDevlieghere requested review of this revision.
Herald added a project: LLDB.

Make sure to add the PrivateFrameworks directory to the frameworks path when using an internal SDK. This is necessary for the "on-device" test suite.

rdar://84519268


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114742

Files:
  lldb/packages/Python/lldbsuite/test/builders/darwin.py


Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -79,6 +79,12 @@
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
+        if 'internal' in configuration.apple_sdk:
+            sdk_root = lldbutil.get_xcode_sdk_root(configuration.apple_sdk)
+            if sdk_root:
+                private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFrameworks')
+                args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
         operating_system, env = get_os_and_env()
         if operating_system and operating_system != "macosx":
             builder_dir = os.path.dirname(os.path.abspath(__file__))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114742.390473.patch
Type: text/x-patch
Size: 880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211129/278df888/attachment.bin>


More information about the lldb-commits mailing list