[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

Fri Nov 19 13:06:25 PST 2021

puremourning added a comment.

In D112222#3141363 <https://reviews.llvm.org/D112222#3141363>, @jingham wrote:

> In D112222#3141355 <https://reviews.llvm.org/D112222#3141355>, @puremourning wrote:
>
>> Sorry, but is anything further required from me on this patch ?
>
> You addressed an issue Shafik asked you to, so then he should make sure he's happy with the change and mark the patch accepted.  OTOH we're all busy so it's easy to let this sort of thing drop.  On your end, you should wait a polite interval then issue a gentle ping in his direction...  A week is an okay interval, I think, so now would be appropriate.

Sure, I wasn't nagging, just checking :) I completely understand how these things go. There's no rush.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112222/new/

https://reviews.llvm.org/D112222