[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Never mind, it seems to be fixed. Although the problem I mentioned is still true where some test cases might set "self.target = debugger.CreateTarget(...)" and if those test cases try to use the check_breakpoint function. See suggested code edit for a potential fix.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:759
+    
+    bkpt = test.target().FindBreakpointByID(bpno)
+    test.assertTrue(bkpt.IsValid(), "Breakpoint is not valid.")
----------------
clayborg wrote:
> This line throws and exception when I run it on my system. It seems we have a function in lldbtest.py:
> ```
>     # utility methods that tests can use to access the current objects
>     def target(self):
>         if not self.dbg:
>             raise Exception('Invalid debugger instance')
>         return self.dbg.GetSelectedTarget()
> ```
> 
> And many tests actually set "self.target" to be a lldb.SBTarget with lines like:
> 
> ```
>         self.target = self.dbg.CreateTarget(exe)
> ```
> 
> So this test fails for many objective C tests now with an exception
You can make this safer by doing the suggested code change




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111899/new/

https://reviews.llvm.org/D111899