[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 18 20:34:41 PST 2021


clayborg added a comment.

This change causes many test suite errors due to inline comment. Please fix ASAP



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:759
+    
+    bkpt = test.target().FindBreakpointByID(bpno)
+    test.assertTrue(bkpt.IsValid(), "Breakpoint is not valid.")
----------------
This line throws and exception when I run it on my system. It seems we have a function in lldbtest.py:
```
    # utility methods that tests can use to access the current objects
    def target(self):
        if not self.dbg:
            raise Exception('Invalid debugger instance')
        return self.dbg.GetSelectedTarget()
```

And many tests actually set "self.target" to be a lldb.SBTarget with lines like:

```
        self.target = self.dbg.CreateTarget(exe)
```

So this test fails for many objective C tests now with an exception


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111899/new/

https://reviews.llvm.org/D111899



More information about the lldb-commits mailing list