[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

[Zequan Wu via Phabricator via lldb-commits]

zequanwu planned changes to this revision.
zequanwu added a comment.

I realized that the test case here is incorrect, because the output of `lldb-test symbols dump-ast ...` shows `void virtual_method()` twice. The `void virtual_method()` without `virtual` is created by the new code. Because `lldb-test symbols dump-ast ...` calls `Module::ParseAllDebugSymbols()` which calls `SymbolFileNativePDB::ParseTypes(CompileUnit &comp_unit)`. It will construct all debug info inside TagDecls found from TPI stream, so the second `void virtual_method()` shows up.

I tried to use this for testing: `lldb-test symbols --find=function --name=full::name --function-flags=full ...`, but it doesn't even shows information for function `main`.

I'm working on another way to fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113930/new/

https://reviews.llvm.org/D113930