[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

The stop id includes all the user expression stops.  So the same "drive through code" could produce very different stop counts if you ran a bunch of `p`-s in one session but not the other.  You can't do better than that at present since we only track the natural/vrs. expression stop id for the last stop.  But if it mattered you could keep a separate "natural stop" counter and report that instead.  You can't quite get back to the natural stops by subtracting the number of expressions, because not all expressions run the target, and some do twice (if the one-thread run times out).

I'm not sure that's terribly important, provided people doing this analysis know that both stops are getting counted, and this is a useful statistic either way.

Anyway, other than that, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113810/new/

https://reviews.llvm.org/D113810