[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

[Greg Clayton via Phabricator via lldb-commits]

clayborg marked 4 inline comments as done.
clayborg added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:713
+  /// is unknown or can't be determined.
+  lldb::addr_t m_length;
+  /// The data for this object file so things can be parsed lazily.
----------------
Because it can be an address in memory as well for object file that are read from memory only with no backing object file on disk


================
Comment at: lldb/include/lldb/Symbol/Symbol.h:22
+}
+}
+
----------------
clang format didn't catch this, as I have it enabled.


================
Comment at: lldb/source/Core/Mangled.cpp:412
+  /// If we have a Mangled object with two different names that are not related
+  /// then we need to save both strings.
+  MangledAndDemangled = 3u
----------------
I will improve the comment on this to explain!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113789/new/

https://reviews.llvm.org/D113789