[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 10 15:16:53 PST 2021


teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

I guess that's just clang-format ran over the file? If yes, then LGTM



================
Comment at: lldb/include/lldb/Symbol/Type.h:86
     eEncodingIsAtomicUID,          ///< This type is the type whose UID is
                                    /// m_encoding_uid as an atomic type.
     eEncodingIsSyntheticUID
----------------
FWIW, we usually update the comments to something less >squished< such as:
```
///< This type is the type whose UID is m_encoding_uid
eEcodingIsUID.
/// This type is the type whose UID is m_encoding_uid with the const qualifier added
eEncodingIsConstUID,
```

I think this patch is good as-is, but there would be bonus points for fixing up the comment style :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113604/new/

https://reviews.llvm.org/D113604



More information about the lldb-commits mailing list